Sql-server – output parameter in SQL

sql serverstored-procedures

I'm trying to pass a new ID onto another procedure but keep getting a "too many parameters" error.

CREATE OR ALTER PROCEDURE dbo.Process_Insert 
  @Name        VARCHAR(50), 
  @IntOnly     INT, 
  @enabled     BIT, 
  @CustomerID  INT, 
  @AllowAttr   BIT, 
  @IsKit       BIT = 0, 
  @Body        NVARCHAR(MAX)=NULL, 
  @new_ident   INT NULL OUTPUT
AS
BEGIN
SET NOCOUNT ON;
INSERT INTO Process
(Name, 
 IntOnly, 
 enabled, 
 CustomerID, 
 AllowAttr, 
 IsKit, 
 Body)
VALUES
(
  @Name, @IntOnly, @enabled, @CustomerID, @AllowAttr, @IsKit, @Body);
SET @new_ident=SCOPE_IDENTITY();
END;

Then in the below procedure I get "Procedure or function has too many arguments specified". I'm guessing it has something to do with the output parameter, but can't work it out.

CREATE OR ALTER PROCEDURE dbo.Customer_Init 
  @CustID INT
AS
DECLARE 
  @vendID INT;
EXEC dbo.Process_Insert 
     @Name="NameOfEntry", 
     @IntOnly=0, 
     @enabled=False, 
     @CustomerID=@CustID, 
     @AllowAttr=False, 
     @Body="test", 
     @new_ident=@vendID OUTPUT;
SELECT @vendID;

Best Answer

You need to pass @IsKit as well, between AllowAttr and Body.

Related Solutions

Handling Exceptions in Stored Procedures with Insert-Exec Blocks

The error in the EXEC part of the INSERT-EXEC statement is leaving your transaction in a doomed state.

If you PRINT out XACT_STATE() in the CATCH block it is set to -1.

Not all errors will set the state to this. The following check constraint error goes through to the catch block and the INSERT succeeds.

ALTER PROCEDURE test -- or create
AS
  BEGIN try
      DECLARE @retval INT;

      DECLARE @t TABLE(x INT CHECK (x = 0))

      INSERT INTO @t
      VALUES      (1)

      SET @retval = 0;

      SELECT @retval;

      RETURN( @retval );
  END try

  BEGIN catch
      PRINT XACT_STATE()

      PRINT ERROR_MESSAGE();

      SET @retval = -1;

      SELECT @retval;

      RETURN( @retval );
  END catch;

Adding this to the CATCH block

 IF (XACT_STATE()) = -1
BEGIN
    ROLLBACK TRANSACTION;
END;

Doesn't help. It gives the error

Cannot use the ROLLBACK statement within an INSERT-EXEC statement.

I don't think there is any way of recovering from such an error once it has happened. For your specific use case you don't need INSERT ... EXEC anyway though. You can assign the return value to a scalar variable then insert that in a separate statement.

DECLARE @RC INT;

EXEC sp_executesql
  N'EXEC @RC = test',
  N'@RC INT OUTPUT',
  @RC = @RC OUTPUT;

INSERT INTO @t
VALUES      (@RC)

Or of course you could restructure the called stored procedure so that it doesn't raise that error at all.

DECLARE @RetVal INT = -1

IF OBJECT_ID('PrintMax', 'P') IS NULL
  BEGIN
      EXEC('create procedure PrintMax as begin print ''hello world'' end;')

      SET @RetVal = 0
  END

SELECT @RetVal;

RETURN( @RetVal );

Sql-server – Oracle GoldenGate add trandata errors

I found out what the problem is, it seems that GoldenGate doesn't work with SQL Express. The server I was connecting to is SQL Express, I'll need to use the Enterprise Edition.

Best Answer

Related Solutions

Handling Exceptions in Stored Procedures with Insert-Exec Blocks

Sql-server – Oracle GoldenGate add trandata errors

Related Question