Parameter sniffing is your friend almost all of the time and you should write your queries so that it can be used. Parameter sniffing helps building the plan for you using the parameter values available when the query is compiled. The dark side of parameter sniffing is when the values used when compiling the query is not optimal for the queries to come.
The query in a stored procedure is compiled when the stored procedure is executed, not when the query is executed so the values that SQL Server has to deal with here...
CREATE PROCEDURE WeeklyProc(@endDate DATE)
AS
BEGIN
DECLARE @startDate DATE = DATEADD(DAY, -6, @endDate)
SELECT
-- Stuff
FROM Sale
WHERE SaleDate BETWEEN @startDate AND @endDate
END
is a known value for @endDate and an unknown value for @startDate. That will leave SQL Server to guessing on 30% of the rows returned for the filter on @startDate combined with whatever the statistics tells it for @endDate. If you have a big table with a lot of rows that could give you a scan operation where you would benefit most from a seek.
Your wrapper procedure solution makes sure that SQL Server sees the values when DateRangeProc is compiled so it can use known values for both @endDate and @startDate.
Both your dynamic queries leads to the same thing, the values are known at compile-time.
The one with a default null value is a bit special. The values known to SQL Server at compile-time is a known value for @endDate and null for @startDate. Using a null in a between will give you 0 rows but SQL Server always guess at 1 in those cases. That might be a good thing in this case but if you call the stored procedure with a large date interval where a scan would have been the best choice it may end up doing a bunch of seeks.
I left "Use the DATEADD() function directly" to the end of this answer because it is the one I would use and there is something strange with it as well.
First off, SQL Server does not call the function multiple times when it is used in the where clause. DATEADD is considered runtime constant.
And I would think that DATEADD is evaluated when the query is compiled so that you would get a good estimate on the number of rows returned. But it is not so in this case.
SQL Server estimates based on the value in the parameter regardless of what you do with DATEADD (tested on SQL Server 2012) so in your case the estimate will be the number of rows that is registered on @endDate. Why it does that I don't know but it has to do with the use of the datatype DATE. Shift to DATETIME in the stored procedure and the table and the estimate will be accurate, meaning that DATEADD is considered at compile time for DATETIME not for DATE.
So to summarize this rather lengthy answer I would recommend the wrapper procedure solution. It will always allow SQL Server to use the values provided when compiling the the query without the hassle of using dynamic SQL.
PS:
In comments you got two suggestions.
OPTION (OPTIMIZE FOR UNKNOWN) will give you an estimate of 9% of rows returned and OPTION (RECOMPILE) will make SQL Server see the parameter values since the query is recompiled every time.
Dynamic SQL is another option. I would try both this method and @a1ex07's method and see which runs faster for you.
CREATE PROCEDURE WorkAssignmentReport @Category varchar(25)
,@---Name varchar(25)
,@Stats varchar(25)
,@---Name varchar(25)
.........
......
DECLARE @sql nvarchar(max)
SET @sql = 'SELECT * ' + CHAR(13) +
'FROM [Ticket] ' + CHAR(13) +
'INNER JOIN dbo.[TicketType] ON [Ticket].TicketTypeID = [TicketType].TicketTypeID ' + CHAR(13) +
'INNER JOIN dbo.[Status] ON [Ticket].Stat .... ' + CHAR(13) +
'..... ' + CHAR(13) +
' ' + CHAR(13) +
' ' + CHAR(13) +
'WHERE 1=1 '
IF @Category IS NOT NULL
SET @sql = @sql + CHAR(13) + ' AND [TicketType].Name LIKE @Category '
IF @ReportName IS NOT NULL
SET @sql = @sql + CHAR(13) + ' AND [Ticket].Name LIKE @ReportName '
IF @Status IS NOT NULL
SET @sql = @sql + CHAR(13) + ' AND [Status].StatusName LIKE @Status '
IF @PhaseName IS NOT NULL
SET @sql = @sql + CHAR(13) + ' AND [Phase].PhaseName LIKE @PhaseName '
IF @Name1 IS NOT NULL
SET @sql = @sql + CHAR(13) + ' AND (BA.FullName = @Name1 OR AD.FullName = @Name1) '
EXEC sp_executesql @sql, N'@Category varchar(25), @ReportName varchar(25), @Status varchar(25), @PhaseName varchar(25), @Name1 varchar(25)',
@Category, @ReportName, @Status, @PhaseName, @Name1
Best Answer
Is there any reason you aren't just using a group by?