Sql-server – how to use the keyword `VALUES` in an `IN` statement

I created a test DB and table, I adjusted the schema to make it a bit easier and also commented out the set in the proc.

USE [Test]
GO

/****** Object:  Table [dbo].[news]    Script Date: 2/4/2017 12:21:07 PM ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[news](
    [id_news] [int] NULL,
    [news_owner_id] [int] NULL,
    [news_owner_type] [bit] NULL,
    [news_cat_id] [int] NULL,
    [news_producer] [nvarchar](1000) NULL,
    [news_title] [nvarchar](1000) NULL,
    [news_sutitr] [nvarchar](1000) NULL,
    [news_text] [nvarchar](1000) NULL,
    [news_date] [nvarchar](128) NULL,
    [news_time] [nvarchar](16) NULL,
    [news_link] [nvarchar](512) NULL,
    [img_uri_type] [tinyint] NULL,
    [img_uri] [xml] NULL,
    [newsContentID] [int] NULL
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]

GO

I'm going to answer 2 first. I ran the proc once, it inserted one time. I looked through the execution plan and it shows a straight forward insert. You can see it here: Standard run. I then set your error handling to 0, just to see the plan with that being triggered. Also straight forward. Error handling triggered. I would run SQL Profiler when you see it insert two records or set up sp_whoisactive to catch the plan when it does multiple inserts. My guess is that it's being executed twice.

For question 1, it looks fine to me. You could put in more exact error handling, but overall I would not say it's bad. I really like this template by spaghetti dba.

As Mark Sinkinson pointed out in his comment, the problem is well described here: Bad habits to kick : using SELECT * / omitting the column list

As the title suggests, your problem was in using * instead of column list in the view.

When I saw * in your code, my first thought was about this problem so I suggested you to use sp_refreshview.

Of course it's not a solution, it was just a small test to understand if the problem was exactly there. The real solution is to rewrite your view with the complete column list instead of *

Here is my small repro to show how it could happen:

create table dbo.t (id int, dt_col datetime, int_col int);
GO

create view dbo.vw_test as 
select *
from dbo.t;
GO

alter table dbo.t drop column dt_col;
go

alter table dbo.t add dt_col datetime;
go

insert dbo.t(id, dt_col, int_col)
values (1, '20180209', 0);

select dt_col
from dbo.vw_test;